Skip to content

Conversation

@gam6itko
Copy link
Contributor

@gam6itko gam6itko commented Apr 22, 2023

if any exec fails - job fails too.

Fixed #17

@gam6itko
Copy link
Contributor Author

@TomasVotruba Hello, can you review this PR please

@alinceDev
Copy link

@TomasVotruba please we need this PR

@danharrin danharrin requested a review from Copilot September 25, 2025 11:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new execOrDie function to handle command execution failures more consistently by automatically terminating the script when any exec command fails. The change addresses issue #17 by replacing direct exec calls with execOrDie throughout the codebase.

  • Adds execOrDie function that checks exit codes and terminates on failure
  • Replaces all exec calls with execOrDie for consistent error handling
  • Removes manual exit code checking logic that is now handled by the new function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

danharrin and others added 2 commits September 25, 2025 12:38
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@danharrin danharrin merged commit 633e3f0 into danharrin:main Sep 25, 2025
2 of 4 checks passed
@gam6itko
Copy link
Contributor Author

Hallelujah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Since using PHP, a git push error does not produce the run to fail

3 participants