Altered CMakeLists.txt specifically for Mac OS Sierra 10.12.6#12
Open
kkuivenhoven wants to merge 2 commits intodaniel-shimon:masterfrom
Open
Altered CMakeLists.txt specifically for Mac OS Sierra 10.12.6#12kkuivenhoven wants to merge 2 commits intodaniel-shimon:masterfrom
kkuivenhoven wants to merge 2 commits intodaniel-shimon:masterfrom
Conversation
daniel-shimon
requested changes
Mar 31, 2021
CMakeLists.txt
Outdated
|
|
||
| set(CMAKE_CXX_STANDARD 17) | ||
| set(CMAKE_EXE_LINKER_FLAGS "-static") | ||
| set(CMAKE_EXE_LINKER_FLAGS) |
Owner
There was a problem hiding this comment.
if(NOT APPLE)
set(CMAKE_EXE_LINKER_FLAGS "-static")
endif()
Author
|
Hey Daniel, Messing around in Vim today with rpp. What is the ideal text editor to work with rpp? For example, I follow the "Hello World" example and this is what appears in Vim: When |
Owner
|
Hey, from my checks the only usable code editor for rpp is notepad++, which you can flip so it will be right-to-left BTW, do you want to fix this PR so I'll merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Daniel,
I made PR as suggested. The CMakeLists.txt no longer has the

staticportion. I followed the install instructions - it installs just fine with the exception of a few Warnings. I have provided a screen shot to show the warnings.