Fix security, reliability, and performance issues in SMDA #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix **Critical DoS in ELF Loader**: Added `MAX_IMAGE_SIZE` check in `ElfFileLoader.py` to prevent unbounded memory allocation from malicious headers. - Fix **Silent PE Corruption**: Added `MAX_IMAGE_SIZE` check in `PeFileLoader.py` and changed behavior to raise `ValueError` instead of silently ignoring limits and producing corrupted mappings. - Fix **Performance DoS in String Extraction**: Updated `detect_ascii_len` and `detect_unicode_len` in `StringExtractor.py` to enforce `maxlen` during iteration, preventing O(N) scans on large buffers. Added bounds checks for initial reads. - Fix **Uncaught Exceptions**: Wrapped `FileLoader` usage in `Disassembler.py` within the main `try/except` block to prevent application crashes on malformed inputs. - Fix **Initialization Crash**: Added check for uninitialized backend in `_disassemble`. - Fix **Global Logging**: Removed `lief.logging.disable()` from library files to respect user configuration. - Refactored `ElfFileLoader.getBaseAddress` to reuse `lief.parse` result, improving performance. - Refactored `BinaryInfo` initialization in `Disassembler.py` to reduce code duplication. - Addressed LIEF parsing robustness by checking for `None` returns. - Applied code formatting.
- Fix **Critical DoS in ELF Loader**: Added `MAX_IMAGE_SIZE` check in `ElfFileLoader.py` to prevent unbounded memory allocation from malicious headers. - Fix **Silent PE Corruption**: Added `MAX_IMAGE_SIZE` check in `PeFileLoader.py` and changed behavior to raise `ValueError` instead of silently ignoring limits and producing corrupted mappings. - Fix **Unbounded Memory in MachO Loader**: Added `MAX_IMAGE_SIZE` check in `MachoFileLoader.py`. - Fix **Performance DoS in String Extraction**: Updated `detect_ascii_len` and `detect_unicode_len` in `StringExtractor.py` to enforce `maxlen` during iteration, preventing O(N) scans on large buffers. Added bounds checks for initial reads. - Fix **Uncaught Exceptions**: Wrapped `FileLoader` usage in `Disassembler.py` within the main `try/except` block to prevent application crashes on malformed inputs. - Fix **Initialization Crash**: Added check for uninitialized backend in `_disassemble`. - Fix **Global Logging**: Removed `lief.logging.disable()` from library files to respect user configuration. Added it to `analyze.py` (CLI entry point). - Refactored `ElfFileLoader.getBaseAddress` to reuse `lief.parse` result, improving performance. - Refactored `BinaryInfo` initialization in `Disassembler.py` to reduce code duplication. - Addressed LIEF parsing robustness by checking for `None` returns. - Applied code formatting.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
- Fix ARM architecture detection: change `==` to `in` for list comparison (the previous code would always return False for ARM architectures) - Add null checks for lief.parse() returns to match ElfFileLoader safety - Add optional macho_file parameter to getBaseAddress() for performance (reuses parsed LIEF object in mapBinary to avoid redundant parsing)
Change default return value for getArchitecture function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.