re-worded some error messages and avoid using product name #8074
+19
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
commented
Jan 2, 2026
|
|
||
| default: | ||
| throw InternalError(nullptr, std::string("Unexpected action '") + action + "' in MathLib::calculate(). Please report this to Cppcheck developers."); | ||
| throw InternalError(nullptr, std::string("Unexpected action '") + action + "' in MathLib::calculate(). Please report this to the developers."); |
Collaborator
Author
There was a problem hiding this comment.
I am not so sure about explicit mentions to report this. I would hope that users are reporting any of the internal errors they cannot fix by themselves.
firewave
force-pushed
the
cppcheck-errstr
branch
from
e21ca8c to
c8bf1a3
Compare
firewave
commented
Jan 2, 2026
| "TemplateSimplifier: max template recursion (" | ||
| + std::to_string(mSettings.maxTemplateRecursion) | ||
| + ") reached for template '"+typeForNewName+"'. You might want to limit Cppcheck recursion.", | ||
| + ") reached for template '"+typeForNewName+"'. You might want to adjust the template recursion limit.", |
Collaborator
Author
There was a problem hiding this comment.
Not sure if we should mention that the limit should be adjusted.
firewave
commented
Jan 2, 2026
Comment on lines
-1254
to
+1255
| msg = "This file is not analyzed. Cppcheck failed to extract a valid configuration. Use -v for more details."; | ||
| msg += "\nThis file is not analyzed. Cppcheck failed to extract a valid configuration. The tested configurations have these preprocessor errors:"; | ||
| msg = "This file is not analyzed. No working configuration could be extracted. Use -v for more details."; | ||
| msg += "\nThis file is not analyzed. No working configuration could be extracted. The tested configurations have these preprocessor errors:"; |
Collaborator
Author
There was a problem hiding this comment.
Aside from dropping the product name I think this explains it better.
firewave
commented
Jan 2, 2026
| ErrorMessage errmsg(std::move(locationList), mFile0, Severity::information, | ||
| (headerType==SystemHeader) ? | ||
| "Include file: <" + header + "> not found. Please note: Cppcheck does not need standard library headers to get proper results." : | ||
| "Include file: <" + header + "> not found. Please note: Standard library headers do not need to be provided to get proper results." : |
Collaborator
Author
There was a problem hiding this comment.
Aside from dropping the product name I think this explains it better.
firewave
force-pushed
the
cppcheck-errstr
branch
from
c8bf1a3 to
72883d3
Compare
|
firewave
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.