Update config rules #5
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the notification filtering configuration system to use a simplified rule-based approach with regex patterns. The main changes replace the complex multi-rule filtering system with direct package matching using regular expressions, and update the default configuration to focus on bank notifications while ignoring social media and system apps.
- Simplified notification filtering logic from complex rule-based system to direct regex package matching
- Updated default configuration to focus on Vietnamese bank apps with comprehensive ignore lists
- Enhanced test coverage with specific scenarios for bank apps and edge cases
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| NotificationFilterEngineTest.kt | Complete test suite rewrite with focused bank app testing and social media ignore scenarios |
| NetworkModule.kt | Added hardcoded base URL for development/testing |
| AppDatabase.kt | Modified database migration configuration |
| WebhookConfig.kt | Restructured data models and default configuration for regex-based filtering |
| NotificationFilterEngine.kt | Simplified filtering logic to use regex matching instead of complex rules |
| app/build.gradle.kts | Added build configuration for webhook URLs and signing |
| README.md | Updated documentation to reflect new architecture and features |
Comments suppressed due to low confidence (2)
app/src/main/java/com/daohoangson/n8n/notificationlistener/data/database/AppDatabase.kt:28
- The parameter 'dropAllTables = true' does not exist in Room's fallbackToDestructiveMigration() method. This method takes no parameters and will cause a compilation error.
).fallbackToDestructiveMigration(dropAllTables = true)
app/src/test/java/com/daohoangson/n8n/notificationlistener/config/NotificationFilterEngineTest.kt:47
- The package name 'com.Slack' uses incorrect capitalization. Android package names are typically lowercase, so this should be 'com.slack' to match real-world package naming conventions.
packageName = "com.Slack",
| .build() | ||
|
|
||
| private val retrofit = Retrofit.Builder() | ||
| .baseUrl("https://google.com") |
There was a problem hiding this comment.
The hardcoded base URL 'https://google.com' appears to be a placeholder or debugging value. This should be replaced with a proper configuration or removed if not needed.
| val urls: List<WebhookUrl>, val ignoredPackages: List<Regex> | ||
| ) | ||
|
|
||
| data class WebhookUrl( | ||
| val url: String, | ||
| val name: String, | ||
| val rules: List<FilterRule> | ||
| ) | ||
|
|
||
| data class FilterRule( | ||
| val packageName: String, | ||
| val titleRegex: Regex? = null, | ||
| val textRegex: Regex? = null | ||
| val url: String, val name: String, val packages: List<Regex> |
There was a problem hiding this comment.
[nitpick] Data class parameters should be placed on separate lines when there are multiple parameters for better readability and maintainability.
| val packageName: String, | ||
| val titleRegex: Regex? = null, | ||
| val textRegex: Regex? = null | ||
| val url: String, val name: String, val packages: List<Regex> |
There was a problem hiding this comment.
[nitpick] Data class parameters should be placed on separate lines when there are multiple parameters for better readability and maintainability.
| val url: String, val name: String, val packages: List<Regex> | |
| val url: String, | |
| val name: String, | |
| val packages: List<Regex> |
| proguardFiles( | ||
| getDefaultProguardFile("proguard-android-optimize.txt"), | ||
| "proguard-rules.pro" | ||
| getDefaultProguardFile("proguard-android-optimize.txt"), "proguard-rules.pro" |
There was a problem hiding this comment.
[nitpick] Function parameters should be placed on separate lines when there are multiple parameters for better readability and maintainability.
| getDefaultProguardFile("proguard-android-optimize.txt"), "proguard-rules.pro" | |
| getDefaultProguardFile("proguard-android-optimize.txt"), | |
| "proguard-rules.pro" |
No description provided.