Skip to content

Conversation

@r001
Copy link

@r001 r001 commented Nov 17, 2017

Minor update to add variable instead of hard coded gas value in delegatecall.

@rainbreak
Copy link
Member

To clarify: this is to future proof ds-proxy against gas pricing changes in the EVM.

@gbalabasquer @NiklasKunkel want to restate any opinions here?

@gbalabasquer
Copy link
Contributor

I'd merge this. I hope the gas prices do not change enough to over pass the 5000, otherwise we will be in a trouble. Then I say in a nice thing to have. My only question would be if there is any added value to declare the variable as uint128 instead of uint256.

@NiklasKunkel
Copy link
Contributor

NiklasKunkel commented Nov 24, 2018 via email

@gbalabasquer
Copy link
Contributor

Yeah I guess the 4200 gas gap should be more than enough, however should it hurt somehow to have it manageable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants