Skip to content

Conversation

@kgal-akl
Copy link

@kgal-akl kgal-akl commented Sep 19, 2025

Description

Added a new Secret Store component for Akeyless.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Issue reference

#4063

Requirements

  • Code compiles correctly, component loaded successfully after compiling local daprd with added Akeyless Secret Store component, secret retrieved:
image

@kgal-akl kgal-akl mentioned this pull request Oct 4, 2025
7 tasks
@kgal-akl kgal-akl marked this pull request as ready for review October 4, 2025 05:09
@kgal-akl kgal-akl requested review from a team as code owners October 4, 2025 05:09
@kgal-akl kgal-akl requested a review from sicoyle October 22, 2025 17:33
@kgal-akl kgal-akl force-pushed the add-akeyless-secretstore branch from a56fc84 to b2a72bf Compare October 22, 2025 19:17
Copy link
Contributor

@sicoyle sicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for iterating with me on this! Here's another batch of feedback for ya - I still have a bit more to review on this, but this is the main I think so far :) 🙌

Copy link

@tuvia-akeyless tuvia-akeyless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please verify (manually/tests) it is working for various types of dynamic and rotated secrets.

@kgal-akl

This comment was marked as outdated.

@kgal-akl kgal-akl requested a review from sicoyle November 11, 2025 18:27
@kgal-akl kgal-akl force-pushed the add-akeyless-secretstore branch 2 times, most recently from 963e468 to a9d88a2 Compare December 1, 2025 18:31
Signed-off-by: Kobbi Gal <kobbi.g@akeyless.io>
@kgal-akl kgal-akl force-pushed the add-akeyless-secretstore branch from bc57bc0 to 2718c8f Compare December 1, 2025 18:38
@kgal-akl
Copy link
Author

kgal-akl commented Dec 1, 2025

@sicoyle - can you please review this again? There were a bunch of merge conflicts and it happens every I update the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants