-
Notifications
You must be signed in to change notification settings - Fork 544
Add Akeyless Secrets Store Component #4036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a56fc84 to
b2a72bf
Compare
sicoyle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for iterating with me on this! Here's another batch of feedback for ya - I still have a bit more to review on this, but this is the main I think so far :) 🙌
tuvia-akeyless
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please verify (manually/tests) it is working for various types of dynamic and rotated secrets.
This comment was marked as outdated.
This comment was marked as outdated.
963e468 to
a9d88a2
Compare
Signed-off-by: Kobbi Gal <kobbi.g@akeyless.io>
bc57bc0 to
2718c8f
Compare
|
@sicoyle - can you please review this again? There were a bunch of merge conflicts and it happens every I update the branch. |
Description
Added a new Secret Store component for Akeyless.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Issue reference
#4063
Requirements