- 
                Notifications
    You must be signed in to change notification settings 
- Fork 224
Adding support for HttpPipeline #1585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
6c82a33    to
    187f29e      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI looks to be all red, mind taking a look and fixing up CI to be green again?
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
7e1b673    to
    81d5448      
    Compare
  
    | @cicoyle checkstyle issue fixed | 
| @salaboy the codecov is failing. Can you please take a look ? | 
| Codecov Report❌ Patch coverage is  Additional details and impacted files@@             Coverage Diff              @@
##             master    #1585      +/-   ##
============================================
+ Coverage     76.91%   78.46%   +1.54%     
- Complexity     1592     1935     +343     
============================================
  Files           145      217      +72     
  Lines          4843     5883    +1040     
  Branches        562      660      +98     
============================================
+ Hits           3725     4616     +891     
- Misses          821      928     +107     
- Partials        297      339      +42     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im good with the changes here, but can you add the tests to make codecov pass?
Description
Adding support for HttpPipeline to DaprContainer
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1584
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: