Modernize WebUI Gallery export#17395
Modernize WebUI Gallery export#17395marceloexc wants to merge 4 commits intodarktable-org:masterfrom
Conversation
|
Would be nice to have templates with html and css files in a folder under config/darktable to give users a way to create their own galleries. |
|
let me know what you think about the new padding vertically |
i agree. i think maybe having a templating engine would be a bit too much for the html but i definitely see having the css file available to change so that people can make their own colors, have a different grid layout etc. unfortunately i dont know much about c so i can't volunteer for it. but it is a good idea |
|
@marceloexc : Is that PR still in your scope? Would be nice to fix the CSS issue. |
|
sorry about the long delay, ill get a working commit by this week |
Don't be sorry, all this is done on our free time! |
|
came back to this, i have the correct gap on my machine? when you do inspect element on the browser, do you see the element havingpadding-inline: 20px; padding-block: 40px; applied instead of just padding: 20px?this online gallery works on the devices i tested - could this be a matter of browser cache? |
To me this example doesn't work. In your title "nov9_dt_web_test" you don't have letter having low jamb (don't know the right word, in French - Jambage bas) like g, y, p or q and those letters gets cut. Just try and you'll see. |
|
@marceloexc : Any new about this? |
|
Should we look at #16205 here too? Using CSSbox may satisfy the modernization needs. |
|
Moving this to 5.4 for now. |
Co-authored-by: Bryan Hyshka <hyshka@users.noreply.github.com>
|
i completely forgot about this! This is the extent of my C programming...but darktable-org/lua-scripts#611 does look very interesting |


old webui gallery exporter did not work very well with mobile screens (everything appeared too small and not reactive)
kept the same hanatos style, but started using HTML standard elements (
<header>, <footer>, <figure>, instead of everything being<div> <div> <div>...)switched from xhtml to the html5 (no self closing tags for elements)