Add touchstart event for updating current index #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last commit made the functionality work on Firefox Desktop's Responsive Design mode, but this one further fixes it on mobile, which the last commit did not do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Enabling touch simulation in Firefox's Responsive Design Mode, and in Firefox on Android (and possibly iOS), does not select the tapped suggestion item and put its content into the input.
Why: This fixes suggestion item selection in Firefox when used with a touchscreen.
How: There is a newly registered
touchstartevent handler that does the same thing asonMouseEnterto update the currently selected suggestion item index when a user taps the item. Additionally,touchstartandtouchendevents handlers are added to the document to make sure that touches select the item if the mouse events did not catch them.Checklist: