feat(vue3): improve vue3 support #220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be merged please? :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Vue3 branch is not fully vue3 compatible, this should make it compatible, but I use case is limited, seems to be working more similar to the vue2 version
Why: otherwise it doesn't work on vue3
How: Fixing the slot behaviour also by changing the dependency to vue3 instead of 2.x
Checklist:
This change was only to fix my use case, I haven't made any work to make the test and such work, if you run
yarn buildit will generate files that you can use on the project, it will be good that a version for vue3 would be supported on a npm tag branch.#211