Skip to content

change dynamic to object in operator check -> fix open issue #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

change dynamic to object in operator check -> fix open issue #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 7 additions & 19 deletions lib/version.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,27 +65,23 @@ class Version implements Comparable<Version> {
List<String> get preRelease => List<String>.from(_preRelease);

/// Determines whether the left-hand [Version] represents a lower precedence than the right-hand [Version].
bool operator <(dynamic o) => o is Version && _compare(this, o) < 0;
bool operator <(Object o) => o is Version && _compare(this, o) < 0;

/// Determines whether the left-hand [Version] represents an equal or lower precedence than the right-hand [Version].
bool operator <=(dynamic o) => o is Version && _compare(this, o) <= 0;
bool operator <=(Object o) => o is Version && _compare(this, o) <= 0;

/// Determines whether the left-hand [Version] represents an equal precedence to the right-hand [Version].
@override
bool operator ==(dynamic o) => o is Version && _compare(this, o) == 0;
bool operator ==(Object o) => o is Version && _compare(this, o) == 0;

/// Determines whether the left-hand [Version] represents a greater precedence than the right-hand [Version].
bool operator >(dynamic o) => o is Version && _compare(this, o) > 0;
bool operator >(Object o) => o is Version && _compare(this, o) > 0;

/// Determines whether the left-hand [Version] represents an equal or greater precedence than the right-hand [Version].
bool operator >=(dynamic o) => o is Version && _compare(this, o) >= 0;
bool operator >=(Object o) => o is Version && _compare(this, o) >= 0;

@override
int compareTo(Version? other) {
if (other == null) {
throw ArgumentError.notNull("other");
}

int compareTo(Version other) {
return _compare(this, other);
}

Expand Down Expand Up @@ -188,15 +184,7 @@ class Version implements Comparable<Version> {
build: build, preRelease: preReleaseList);
}

static int _compare(Version? a, Version? b) {
if (a == null) {
throw ArgumentError.notNull("a");
}

if (b == null) {
throw ArgumentError.notNull("b");
}

static int _compare(Version a, Version b) {
if (a.major > b.major) return 1;
if (a.major < b.major) return -1;

Expand Down