-
Notifications
You must be signed in to change notification settings - Fork 290
Add coupler constraint support and example #2212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2212 +/- ##
==========================================
+ Coverage 61.14% 61.24% +0.09%
==========================================
Files 351 352 +1
Lines 31317 31515 +198
Branches 4050 4078 +28
==========================================
+ Hits 19148 19300 +152
- Misses 12169 12215 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
7130579 to
60c2e17
Compare
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Aditya Pande <aditya0509951@gmail.com>
Signed-off-by: Aditya Pande <aditya050995@gmail.com>
b762ad8 to
67e47f0
Compare
67e47f0 to
3ae932a
Compare
|
Merging now. If anything still isn't working or you hit new issues, let me know and I'll fix it forward. Thanks! |
CouplerConstraintso mimic joints can optionally be enforced bilaterally and ensure the constraint solver instantiates it only whenJoint::setUseCouplerConstraint(true)is setTesting
pixi run test-allpixi run ex coupler_constraintScreencast.from.2025-11-18.06-16-25.mp4
Closes #1835
Before creating a pull request
pixi run test-allto lint, build, and test your changes