[WIP] Fixing and improving algorithms with view expressions#410
Open
fuchsto wants to merge 192 commits intodevelopmentfrom
Open
[WIP] Fixing and improving algorithms with view expressions#410fuchsto wants to merge 192 commits intodevelopmentfrom
fuchsto wants to merge 192 commits intodevelopmentfrom
Conversation
…192-nviews Conflicts: dash/include/dash/pattern/SeqTilePattern.h
…e and view traits
This was referenced May 20, 2017
bertwesarg
reviewed
May 24, 2017
| }; | ||
|
|
||
| } // namespace dash | ||
| } // namespace internal |
…o feat-192-nviews
…ash into feat-192-nviews
This was referenced Nov 14, 2017
…192-nviews Conflicts: CMakeLists.txt dart-impl/mpi/src/dart_communication.c dash/include/dash/Iterator.h dash/include/dash/Types.h dash/include/dash/algorithm/Copy.h dash/include/dash/view/ViewTraits.h
…192-nviews Conflicts: CMakeExt/CompilerFlags.cmake CMakeLists.txt dash/CMakeLists.txt dash/examples/CMakeLists.txt dash/include/dash/Iterator.h dash/include/dash/Types.h dash/include/dash/algorithm/Copy.h dash/include/dash/algorithm/Transform.h dash/include/dash/iterator/GlobIter.h dash/test/algorithm/CopyTest.cc
…eat-192-nviews Conflicts: CMakeLists.txt dart-impl/mpi/src/dart_communication.c dash/include/dash/Types.h dash/include/dash/algorithm/Copy.h dash/include/dash/view/Domain.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #346, among others.
A diff that demonstrates the benefit of view expressions pretty well:
https://github.com/dash-project/dash/pull/410/files#diff-c4c2bc3b549c09735c61251a8f8d8ecfR1149
With view expressions,
dash::copy(lbegin, lend, gbegin)is now supported and also allows non-contiguous global destination ranges (blocked, strided, anything a pattern might define).Its full implementation:
Also added example
ex.02.array-viewsfor illustration:https://github.com/dash-project/dash/blob/feat-192-nviews/dash/examples/ex.02.array-views/main.cpp
Output: