fix: incorrect fee calculation for platform-to-platform addresses transfer#514
Closed
fix: incorrect fee calculation for platform-to-platform addresses transfer#514
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lklimek
added a commit
that referenced
this pull request
Feb 24, 2026
… max() Add unified fee methods to PlatformFeeEstimator that compute max(legacy, transition-based) internally, so callers don't need to know about the dual estimation strategy. Consolidates changes from PR #521 and PR #514 into centralized estimator methods. New public methods: - estimate_platform_to_core_fee() - estimate_platform_to_platform_fee() - estimate_core_to_platform_fee() - estimate_identity_create_from_addresses_fee() - estimate_identity_topup_from_addresses_fee() Reduce public API surface: - Make internal helpers private (calculate_processing_fee, calculate_seek_fee, calculate_storage_fee, etc.) - Remove dead code (estimate_masternode_vote, storage_fees(), estimate_address_credit_withdrawal, estimate_contract_create_detailed) Callers updated: send_screen, register_identity, identity/mod, add_new_identity_screen, top_up_identity_screen. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Replaced by #651 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by dashpay/platform#3040 (comment)