Skip to content

fix: add iteration limit to SPV fee calculation loop #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lklimek merged 1 commit into from
Feb 26, 2026
Merged

fix: add iteration limit to SPV fee calculation loop #620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/backend_task/core/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,11 +499,13 @@ impl AppContext {
.map(|h| h.current_height())
})
.ok_or("Cannot build transaction: SPV sync height is not yet known")?;
const MAX_FEE_ITERATIONS: usize = 50;

let total_amount: u64 = recipients.iter().map(|(_, amt)| *amt).sum();
let mut scale_factor = 1.0f64;
let mut attempted_fallback = false;

loop {
for _ in 0..MAX_FEE_ITERATIONS {
let scaled_recipients: Vec<(Address, u64)> = recipients
.iter()
.map(|(addr, amt)| (addr.clone(), (*amt as f64 * scale_factor) as u64))
Expand Down Expand Up @@ -545,6 +547,8 @@ impl AppContext {
}
}
}

Err("Could not build transaction after maximum fee adjustment attempts".to_string())
}

fn estimate_fallback_amount(
Expand Down
Loading