Skip to content

fix: add 30-second timeout to SPV quorum public key lookup #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thepastaclaw wants to merge 2 commits into from
Closed

fix: add 30-second timeout to SPV quorum public key lookup #621

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6db301
fix: add 30-second timeout to SPV quorum public key lookup
thepastaclaw Feb 22, 2026
f5993b8
fix(spv): use tracing formatting in quorum timeout warning
thepastaclaw Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 38 additions & 22 deletions src/spv/manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,28 +643,44 @@ impl SpvManager {

tokio::task::block_in_place(|| {
tokio::runtime::Handle::current().block_on(async {
interface
.get_quorum_by_height(core_chain_locked_height, llmq_type, qh)
.await
.map(|q| {
tracing::debug!(
"Quorum public key found: type={}, hash={}, height={}",
quorum_type,
hex::encode(quorum_hash),
core_chain_locked_height
);
*q.quorum_entry.quorum_public_key.as_ref()
})
.map_err(|e| {
tracing::warn!(
"Quorum lookup failed at height {} for llmq_type={} hash=0x{}: {}",
core_chain_locked_height,
quorum_type,
hex::encode(quorum_hash),
e
);
e.to_string()
})
tokio::time::timeout(
std::time::Duration::from_secs(30),
interface.get_quorum_by_height(core_chain_locked_height, llmq_type, qh),
)
.await
.map_err(|_| {
tracing::warn!(
"Quorum lookup timed out after 30s at height {} for llmq_type={} hash=0x{}",
core_chain_locked_height,
quorum_type,
hex::encode(quorum_hash),
);
format!(
"Quorum lookup timed out after 30s at height {} for llmq_type={} hash=0x{}",
core_chain_locked_height,
quorum_type,
hex::encode(quorum_hash),
)
})?
.map(|q| {
tracing::debug!(
"Quorum public key found: type={}, hash={}, height={}",
quorum_type,
hex::encode(quorum_hash),
core_chain_locked_height
);
*q.quorum_entry.quorum_public_key.as_ref()
})
.map_err(|e| {
tracing::warn!(
"Quorum lookup failed at height {} for llmq_type={} hash=0x{}: {}",
core_chain_locked_height,
quorum_type,
hex::encode(quorum_hash),
e
);
e.to_string()
})
})
})
}
Expand Down
Loading