Skip to content

fix(ui): replace f64 precision-lossy max amount calculation with integer arithmetic #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thepastaclaw wants to merge 1 commit into
base: v1.0-dev
Choose a base branch
from
+4 −4
Draft

fix(ui): replace f64 precision-lossy max amount calculation with integer arithmetic #622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ui/identities/transfer_screen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,8 @@ impl TransferScreen {
ui.add_space(5.0);

// Calculate max amount minus fee for the "Max" button
let max_amount_minus_fee = (self.max_amount as f64 / 100_000_000_000.0 - 0.0002).max(0.0);
let max_amount_credits = (max_amount_minus_fee * 100_000_000_000.0) as u64;
// 0.0002 DASH = 20_000_000 credits (1 DASH = 100_000_000_000 credits)
let max_amount_credits = self.max_amount.saturating_sub(20_000_000);

let amount_input = self.amount_input.get_or_insert_with(|| {
AmountInput::new(Amount::new_dash(0.0))
Expand Down
4 changes: 2 additions & 2 deletions src/ui/identities/withdraw_screen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ impl WithdrawalScreen {
}

fn render_amount_input(&mut self, ui: &mut Ui) {
let max_amount_minus_fee = (self.max_amount as f64 / 100_000_000_000.0 - 0.005).max(0.0);
let max_amount_credits = (max_amount_minus_fee * 100_000_000_000.0) as u64;
// 0.005 DASH = 500_000_000 credits (1 DASH = 100_000_000_000 credits)
let max_amount_credits = self.max_amount.saturating_sub(500_000_000);

// Lazy initialization with basic configuration
let amount_input = self.withdrawal_amount_input.get_or_insert_with(|| {
Expand Down
Loading