Skip to content

Fix condition in zeros() to properly check for non-empty arrays for NumPy 2.x compatibility#110

Closed
xlt208 wants to merge 1 commit intodask:mainfrom
xlt208:main
Closed

Fix condition in zeros() to properly check for non-empty arrays for NumPy 2.x compatibility#110
xlt208 wants to merge 1 commit intodask:mainfrom
xlt208:main

Conversation

@xlt208
Copy link
Contributor

@xlt208 xlt208 commented Aug 20, 2025

@xlt208
Copy link
Contributor Author

xlt208 commented Aug 20, 2025

Hi @milesgranger, could you please review this PR?

@milesgranger
Copy link
Collaborator

Hi @xlt208, PR itself looks good - CI is unhappy w/ some outdated action:

Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v3. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

I assume it's okay to merge and fix that in a follow-up, but I'll defer to the wisdom of @fjetter since I'm not so active here any longer. :)

@xlt208
Copy link
Contributor Author

xlt208 commented Aug 21, 2025

@milesgranger - Thank you!
@fjetter - Please let me know if there's anything else I can do to help.

@jerry-kobold
Copy link

Hi all, apologies for resurrecting this but I'm wondering if there's any chance that this could get merged (and maybe a release put out with the result)? It's a blocker for anyone trying to update to numpy>=2.0 which at this point is a lot of people (including my organization).

@mrocklin
Copy link
Member

Sorry for the lack of engagement here. I'll take a look at this.

@mrocklin
Copy link
Member

Sorry for the very long delay. This has been merged into main.

@mrocklin mrocklin closed this Jan 24, 2026
@xlt208
Copy link
Contributor Author

xlt208 commented Jan 24, 2026

@mrocklin - Thanks for much for working on this! Did you know when a new release would be available with this fix included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants