Conversation
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks for adding this @pentschev, this PR looks really good!
Minor comment: could you please add an n_iter_ attribute to the estimator docstrings
Also, as you mentioned, these changes will cause breakage in dask-ml. Do you have an interest in updating the estimators over there too? Definitely no obligation though, just wanted to check
Yes, thanks for pointing that I forgot it.
Yes, I planned to do that once this was merged, I think there's no point in already opening an PR there before this gets reviewed here. |
Awesome, thank you @pentschev |
|
From my side, this is ready for another review/merge. |
|
Are we good to merge this? |
After this is merged, Dask-ML must be adapted to this change as well.
https://github.com/dask/dask-ml/blob/master/dask_ml/linear_model/glm.py#L187
Solves #77.