-
-
Notifications
You must be signed in to change notification settings - Fork 746
Use default scheduler port for LocalCluster #8760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -123,7 +123,7 @@ def __init__( | |
| start=None, | ||
| host=None, | ||
| ip=None, | ||
| scheduler_port=0, | ||
| scheduler_port=None, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, why is this changed to
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. so There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this documented somewhere? We could probably use some Enum between the two choices?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the default port itself is mentioned somewhere in the docs. Going with enum is possible, though I'd not call it worth it in this case, I mean, the mind that this PR is just meant as a small incremental improvement to unify behaivours a bit |
||
| silence_logs=logging.WARN, | ||
| dashboard_address=":8787", | ||
| worker_dashboard_address=None, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line is what causes the test
distributed/deploy/tests/test_local.py::test_Client_twiceto fail, if I just comment the warning, it passes. Should I remove the warning, change it tologgerinvocation instead, or is there some means of making the test accept a warning occurrence?