-
Notifications
You must be signed in to change notification settings - Fork 17
BLD/DEV: switch to meson-python and pixi-build #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
1e7212e to
b2ee65f
Compare
a28bd6f to
db58474
Compare
This comment was marked as resolved.
This comment was marked as resolved.
rgommers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lucascolley, this looks close. I didn't test yet, but hopefully the comments will be enough to resolve the remaining failures first.
b4efc62 to
bccf112
Compare
lucascolley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rgommers ready to go I think!
| @@ -1,8 +1,8 @@ | |||
| 1. Update the version in `src/array_api_extra/__init__.py` | |||
| 1. Update the version in `pyproject.toml`, `meson.build`, and `src/array_api_extra/__init__.py` | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
up to 3 sources now, I don't think pixi-build is smart enough to handle dynamic versioning yet. But I think it's okay.
| ### array-api-extra package definition ### | ||
|
|
||
| [tool.pixi.package.build.backend] | ||
| name = "pixi-build-python" | ||
| version = "*" | ||
|
|
||
| [tool.pixi.package.host-dependencies] | ||
| meson-python = "*" | ||
|
|
||
| [tool.pixi.package.run-dependencies] | ||
| array-api-compat = "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched over to pixi-build, much saner for ensuring we have ninja etc. in the environment when we need it.
| ### workspace environments ### | ||
|
|
||
| [tool.pixi.environments] | ||
| default = { features = ["py313"], solve-group = "py313" } | ||
| lint = { features = ["py313", "lint"], solve-group = "py313" } | ||
| docs = { features = ["py313", "docs"], solve-group = "py313" } | ||
| tests = { features = ["py313", "tests"], solve-group = "py313" } | ||
| tests-py313 = { features = ["py313", "tests"], solve-group = "py313" } # alias of tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just moved up from below, it is clearer to keep environment definitions at the top IMO
| [tool.pixi.dev] | ||
| # this pulls in array-api-extra's host and run dependencies | ||
| array-api-extra.path = "." | ||
|
|
||
| [tool.pixi.dependencies] | ||
| array-api-compat = ">=1.12.0,<2" | ||
| array-api-extra.path = "." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally we wouldn't need both of these, I have asked offline
bccf112 to
72c6a74
Compare
scipy/scipy#24271