Add adjustable password length and tabu list for recently used passwords#87
Conversation
|
This has good potential but there are various problems, most notably the use of |
|
@ThrawnCA Thank you very much for your review! |
| import six | ||
| import string | ||
|
|
||
| import six |
There was a problem hiding this comment.
six is a good library, but...is this plugin actually compatible with Python 2? If not, then there's no point.
There was a problem hiding this comment.
git blame says you introduced it 2021 😄
We could lose the library but that would be out of scope for this PR, since we did not touch any of its occurrences, I think.
There was a problem hiding this comment.
git blame says you introduced it 2021
Sure. In 2021, CKAN 2.8, and thus Python 2, were still current.
There was a problem hiding this comment.
I just wondered where six came from, that's why I mentioned it. :) Please don't take that as criticism.
I just open an issue to track this so it can be done in another PR.
|
Looking better :)
|
I looked at https://en.wikipedia.org/wiki/Tabu_search to see if it is well known in english, but then we switch to blacklist, which is more widely spread in applications. :) |
…omply with security
…recently used passwords")
230ec37 to
c73b8d3
Compare
We made several improvements to this plugin that are based on each other. We have included all improvements in this PR, it's a bit messy, but if needed, we can talk and maybe find a good way to split them up.
What we have done: