Skip to content

Add adjustable password length and tabu list for recently used passwords#87

Open
seitenbau-govdata wants to merge 12 commits intodata-govt-nz:masterfrom
Seitenbau-Open-Data:feature/adjustable-password-length-and-tabu-list
Open

Add adjustable password length and tabu list for recently used passwords#87
seitenbau-govdata wants to merge 12 commits intodata-govt-nz:masterfrom
Seitenbau-Open-Data:feature/adjustable-password-length-and-tabu-list

Conversation

@seitenbau-govdata
Copy link

We made several improvements to this plugin that are based on each other. We have included all improvements in this PR, it's a bit messy, but if needed, we can talk and maybe find a good way to split them up.

What we have done:

  • added tests
  • added translations (and included a german translation)
  • add config declaration
  • bugfix for newer CKAN, session object changed and have no "invalidate" method anymore
  • if used with https://github.com/keitaroinc/ckanext-saml2auth, we patch the other extension to use the password generation of this extension - so generated passwords comply with the requirements defined here

@ThrawnCA
Copy link
Contributor

This has good potential but there are various problems, most notably the use of random to generate the password.

@seitenbau-govdata
Copy link
Author

@ThrawnCA Thank you very much for your review!

import six
import string

import six
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

six is a good library, but...is this plugin actually compatible with Python 2? If not, then there's no point.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git blame says you introduced it 2021 😄
We could lose the library but that would be out of scope for this PR, since we did not touch any of its occurrences, I think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git blame says you introduced it 2021

Sure. In 2021, CKAN 2.8, and thus Python 2, were still current.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wondered where six came from, that's why I mentioned it. :) Please don't take that as criticism.
I just open an issue to track this so it can be done in another PR.

@ThrawnCA
Copy link
Contributor

Looking better :)

TABULIST still appears in a bunch of places, which at first glance looks like something table-related. "Tabu" is a pretty esoteric word in English, plus it's more usually spelled "taboo", so I think "blacklist" is the simpler and clearer choice.

@seitenbau-govdata
Copy link
Author

Looking better :)

TABULIST still appears in a bunch of places, which at first glance looks like something table-related. "Tabu" is a pretty esoteric word in English, plus it's more usually spelled "taboo", so I think "blacklist" is the simpler and clearer choice.

I looked at https://en.wikipedia.org/wiki/Tabu_search to see if it is well known in english, but then we switch to blacklist, which is more widely spread in applications. :)

@seitenbau-govdata seitenbau-govdata force-pushed the feature/adjustable-password-length-and-tabu-list branch from 230ec37 to c73b8d3 Compare July 16, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants