Fix spinner interference with debug logs #3994
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varundeepsaini
requested review from
andrewnester,
anton-107,
denik,
jefferycheng1,
kanterov,
lennartkats-db,
pietern and
shreyas-goenka
as code owners
Contributor
Author
|
Hey @denik @andrewnester @nfx |
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #931
Changes
Implemented a lock-free coordinated writer to synchronize spinner and logger writes to stderr. All stderr writes now go through a channel-based coordinator that pauses the spinner during log output.
Why
The spinner was interfering with debug log messages, causing visual jumbling in the terminal output. Both were writing to stderr concurrently without coordination.
Tests
coordinatedWriter, including concurrent write scenarios