Open
Conversation
nicklan
reviewed
Mar 29, 2018
Collaborator
nicklan
left a comment
nicklan
left a comment
There was a problem hiding this comment.
Thanks, this is cool! A couple of small nits on the README changes and we should be able to merge it.
README.md
Outdated
|
|
||
| ## Docker build | ||
|
|
||
| `docker run --rm -it -v $HOME/.kube/:/root/.kube/ click` |
Collaborator
There was a problem hiding this comment.
This isn't right is it? It should be something like docker build -t click . in the click directory?
|
|
||
| ## Docker | ||
|
|
||
| `docker run --rm -it -v $HOME/.kube/:/root/.kube/ click` |
Collaborator
There was a problem hiding this comment.
Could you add a note that if any of your certificates are stored outside the .kube dir you'll need to bind that in as well?
There was a problem hiding this comment.
There's also the issue of kubectl configurations that use other commands to gather auth info (e.g. gcloud for GKE clusters).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.