Fix: Allow custom client to be passed to ChatDatabricks (Issue #128)#131
Open
jayshrivastava0 wants to merge 2 commits intodatabricks:mainfrom
Open
Fix: Allow custom client to be passed to ChatDatabricks (Issue #128)#131jayshrivastava0 wants to merge 2 commits intodatabricks:mainfrom
jayshrivastava0 wants to merge 2 commits intodatabricks:mainfrom
Conversation
This commit addresses issue databricks#128 by modifying the `__init__` method of the `ChatDatabricks` class to allow a custom client to be passed in via the constructor. Previously, any client passed in the constructor would be overwritten by the default client. With this change: - If a `client` is provided in `kwargs`, that client instance is used. - Otherwise, the client is initialized using `get_deployment_client(self.target_uri)`. A new unit test, `test_chat_model_with_custom_client`, has been added to `integrations/langchain/tests/unit_tests/test_chat_models.py` to verify this functionality. The test ensures that the provided custom client is correctly assigned and its methods are called when the `ChatDatabricks` instance makes predictions.
…ks-128 Fix: Allow custom client to be passed to ChatDatabricks This commit addresses issue databricks#128 by modifying the `__init__` method of the `ChatDatabricks` class to allow a custom client to be passed in via the constructor. Previously, any client passed in the constructor would be overwritten by the default client. With this change: - If a `client` is provided in `kwargs`, that client instance is used. - Otherwise, the client is initialized using `get_deployment_client(self.target_uri)`. A new unit test, `test_chat_model_with_custom_client`, has been added to `integrations/langchain/tests/unit_tests/test_chat_models.py` to verify this functionality. The test ensures that the provided custom client is correctly assigned and its methods are called when the `ChatDatabricks` instance makes predictions.
Contributor
|
@jayshrivastava0 what is the usecase for passing in the client directly? What kind of clients are you passing in here? |
Author
|
Hey @aravind-segu, great question. We enabled this to give developers more flexibility. The two main use cases are:
The client just needs to be an object that behaves like MLflow's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses issue #128 by modifying the
__init__method of theChatDatabricksclass to allow a custom client to be passed in via the constructor.Previously, any client passed in the constructor would be overwritten by the default client. With this change:
clientis provided inkwargs, that client instance is used.get_deployment_client(self.target_uri).A new unit test,
test_chat_model_with_custom_client, has been added tointegrations/langchain/tests/unit_tests/test_chat_models.pyto verify this functionality. The test ensures that the provided custom client is correctly assigned and its methods are called when theChatDatabricksinstance makes predictions.