-
Notifications
You must be signed in to change notification settings - Fork 47
Langchain Vector Search Tool uses MCP under the hood #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nisha2003
wants to merge
11
commits into
mcp-migration
Choose a base branch
from
langchain-vs-uses-mcp-adapters
base: mcp-migration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
964e88a
changes
nisha2003 d5bebb8
ruff
nisha2003 2a8d33f
clean up langchain tests
nisha2003 ebfc4b9
revert
nisha2003 ce9745f
refactor tests
nisha2003 acb745b
async fix attempt
nisha2003 edf8b3f
debug
nisha2003 b0fd83c
fix langchain format
nisha2003 0015beb
cleanup comments
nisha2003 13d31cd
review comments
nisha2003 9194af1
test fixes
nisha2003 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was just curious here, before _run returns a str and now it returns a List[Document]. Did we change something or was the previous return type wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it maybe have been wrong? Previously we just returned
self._vector_store.similarity_search(**kwargs)for which the return type isList[Document].