Open
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ckpoint_ns - Make cleanup fixtures module-scoped to avoid dropping tables between tests (PostgresStore/Saver track migrations internally) - Add missing checkpoint_ns to all checkpoint config dicts - Remove stale table-tracking append/extend calls Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Drop store_migrations, vector_migrations, store_vectors tables in cleanup fixture (PostgresStore skips setup if migration table exists) - Add auth_type="pat" to create_workspace_client_with_token to avoid oauth+pat conflict when DATABRICKS_CLIENT_ID env var is set Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jennsun
reviewed
Feb 24, 2026
jennsun
reviewed
Feb 24, 2026
integrations/langchain/tests/integration_tests/test_langchain_lakebase.py
Outdated
Show resolved
Hide resolved
jennsun
reviewed
Feb 25, 2026
integrations/langchain/tests/integration_tests/test_langchain_lakebase.py
Show resolved
Hide resolved
jennsun
reviewed
Feb 25, 2026
integrations/langchain/tests/integration_tests/test_langchain_lakebase.py
Outdated
Show resolved
Hide resolved
jennsun
reviewed
Feb 25, 2026
integrations/langchain/tests/integration_tests/test_langchain_lakebase.py
Outdated
Show resolved
Hide resolved
jennsun
reviewed
Feb 25, 2026
integrations/langchain/tests/integration_tests/test_langchain_lakebase.py
Show resolved
Hide resolved
jennsun
requested changes
Feb 25, 2026
Contributor
jennsun
left a comment
There was a problem hiding this comment.
these tests are looking great! my main request is to add a test that tests the core value databricksstore brings to agents (semantic search)
https://github.com/databricks/databricks-ai-bridge/pull/346/changes#r2850132619
jennsun
reviewed
Feb 26, 2026
integrations/langchain/tests/integration_tests/test_langchain_lakebase.py
Show resolved
Hide resolved
jennsun
reviewed
Feb 26, 2026
integrations/langchain/tests/integration_tests/test_langchain_lakebase.py
Outdated
Show resolved
Hide resolved
jennsun
reviewed
Feb 26, 2026
integrations/langchain/tests/integration_tests/test_langchain_lakebase.py
Show resolved
Hide resolved
jennsun
reviewed
Feb 26, 2026
integrations/langchain/tests/integration_tests/test_langchain_lakebase.py
Show resolved
Hide resolved
jennsun
approved these changes
Feb 26, 2026
Contributor
jennsun
left a comment
There was a problem hiding this comment.
thanks for the updates! can we make sure we have coverage/parallel tests for both sync + async versions of the lakebase langchain classes? good to merge after those are synced :)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…__/__exit__) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
annzhang-db
reviewed
Mar 3, 2026
integrations/langchain/tests/integration_tests/test_langchain_lakebase.py
Outdated
Show resolved
Hide resolved
…pool closed Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… in put_and_get Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bbqiu
reviewed
Mar 3, 2026
integrations/langchain/tests/integration_tests/test_langchain_lakebase.py
Show resolved
Hide resolved
bbqiu
reviewed
Mar 3, 2026
integrations/langchain/tests/integration_tests/test_langchain_lakebase.py
Outdated
Show resolved
Hide resolved
bbqiu
reviewed
Mar 3, 2026
integrations/langchain/tests/integration_tests/test_langchain_lakebase.py
Show resolved
Hide resolved
…helper, fixture docs
- Move all imports to top level with pytest.importorskip("langgraph") guard
- Extract _make_checkpoint() helper shared across sync/async tests
- Clarify scope="module" behavior in fixture docstrings
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added LangChain Lakebase integration tests covering
DatabricksStore(sync + async) andCheckpointSaver(sync + async) wrappers. Tests validate the bridge code's behavior — pool creation, connection borrowing,_with_storehandoff, andasync withlifecycle management — against a live Databricks Lakebase instance.Test plan
LAKEBASE_INSTANCE_NAMEtest_store.py,test_checkpoint.py) still pass (16/16)