fix: generate openai compliant response_format payload with json_schema method#351
Open
ktzsh wants to merge 2 commits intodatabricks:mainfrom
Open
fix: generate openai compliant response_format payload with json_schema method#351ktzsh wants to merge 2 commits intodatabricks:mainfrom
ktzsh wants to merge 2 commits intodatabricks:mainfrom
Conversation
jennsun
requested changes
Mar 1, 2026
Contributor
jennsun
left a comment
jennsun
left a comment
There was a problem hiding this comment.
Hi thanks sm for the fix! Core changes look good, ran unit tests locally and saw failures (would have been caught by CI but also good to test on own first) -- could we revert the raw json schema definition and instead update the test to validate structural properties (see comments)?
can you also add test coverage to cover:
- pydantic schema produces a valid response_format
- raw dict schema produces a valid response_format
- nested Pydantic model to validate $ref dereferencing?
Author
|
@jennsun The test should now cover all nested, pydantic or raw json schema |
Contributor
|
@ktzsh ran workflow checks again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to fix #350