Skip to content

Fix OAuth refresh token rotation#1251

Closed
gopalldb wants to merge 1 commit intomainfrom
gopal.lal/fix-oauth-refresh-token-rotation
Closed

Fix OAuth refresh token rotation#1251
gopalldb wants to merge 1 commit intomainfrom
gopal.lal/fix-oauth-refresh-token-rotation

Conversation

@gopalldb
Copy link
Copy Markdown
Collaborator

@gopalldb gopalldb commented Mar 4, 2026

Summary

  • Fixed OAuthRefreshCredentialsProvider to update its stored token after each refresh, so that if the server rotates the refresh token, subsequent refreshes use the new one instead of the stale original.
  • Made the token field volatile for thread safety.

Test plan

  • Added should_UseRotatedRefreshTokenOnSubsequentRefresh test verifying the rotated token is stored after refresh
  • Run mvn test -pl . -Dtest=OAuthRefreshCredentialsProviderTest

🤖 Generated with Claude Code

Update stored token after each refresh so subsequent refreshes use the
latest refresh token when the server rotates it.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Gopal Lal <gopal.lal@databricks.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

This PR has been marked as Stale because it has been open for 30 days with no activity. If you would like the PR to remain open, please remove the stale label or comment on the PR.

@github-actions github-actions Bot added the Stale label Apr 8, 2026
@github-actions
Copy link
Copy Markdown

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions Bot closed this Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant