Fix the JDK8 github action + make local build developer friendly + fix coverage#1255
Conversation
.flattened-pom.xml files generated by flatten-maven-plugin were accidentally committed. Remove them and add to .gitignore to prevent recurrence. Signed-off-by: samikshya-chand_data <samikshya.chand@databricks.com>
tejassp-db
left a comment
tejassp-db
left a comment
There was a problem hiding this comment.
In prCheck.yml the following line is sufficient mvn -pl jdbc-core clean test -Dgroups='!Jvm17PlusAndArrowToNioReflectionDisabled' jacoco:report. If it works here then there is no need to add a profile for local. Why is it not working here?
|
@tejassp-db , For your comment In short - the local profile is just a convenience shortcut for developers here |
Keep in mind that jdk8 branch is 3 months old
All Arrow tests are tagged with Jvm17PlusAndArrowToNioReflectionDisabled and run only via dedicated CI steps, not the general coverage run. Excluding them from the JaCoCo report prevents a false coverage drop. Signed-off-by: samikshya-chand_data <samikshya.chand@databricks.com>
samikshya-db
changed the title
| restore-keys: ${{ runner.os }}-jdk8-m2 | ||
|
|
||
| - name: Run Unit Tests | ||
| run: mvn -pl jdbc-core clean test -Dgroups='!Jvm17PlusAndArrowToNioReflectionDisabled' |
There was a problem hiding this comment.
Should this be using the local profile defined ind jdbc-core/pom.xml?
There was a problem hiding this comment.
As discussed offline, the jdk-8 branch is 2 months old and it will not recognise the new command.
In case we happen to update the branch, the repo actions workflows will fail. In which case, we will have to update the workflow if we update the branch.
tejassp-db
left a comment
tejassp-db
left a comment
There was a problem hiding this comment.
LGTM with the known caveat that this branch is behind master, and will be merged in the future.
2 participants
Description
mvn clean test)Testing
mvn -pl jdbc-core -Plocal clean testmvn -pl jdbc-core,assembly-uber install -PlocalAdditional Notes to the Reviewer
Note : arrow specific tests are not relevant in jdk8 branch as it is specific for JDK16+
NO_CHANGELOG=true