Extend max token stale period buffer with dynamic computation based on TTL#1293
Merged
mihaimitrea-db merged 12 commits intomainfrom Mar 2, 2026
Merged
Conversation
… short-lived tokens. Introduce a max stale period of 20 minutes (previously a flat of 5 minutes for all token types), that dinamically scales down based on the token's TTL. The stale period is now computed at token acquisition time as: min(TTL x 0.5, max_stale_period).
Modify the MockRefreshable to work with the dynamic stale period. You can now override the dynamic refresh, but otherwise it will default to it. Add test_dynamic_stale_period test which verifies the whole fresh -> stale -> async refresh -> expired -> blobking refresh lifecycle for each of the three types of expected token lifespans (90 mins, 10 mins, 90 sec).
Signed-off-by: mihaimitrea-db <mihai.mitrea@databricks.com>
When the TTL is < 0 (the token is expired) the stale period is set to 0 to avoid having a negative stale period.
…fer_extension' into auth_token_buffer_extension
…ment Reintroduce the stale_period attribute in the Refreshable constructor for backwards compatibility as an optional field. If it is present default back to the legacy fixed stale period of 5 minutes. If it is not present the dynamic stale period based on the token's TTL is used. The _use_dynamic_stale_duration flag is used to differentiate between these two methods.
mihaimitrea-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mihaimitrea-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mihaimitrea-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mihaimitrea-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mihaimitrea-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mihaimitrea-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mihaimitrea-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mihaimitrea-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
| # Config properties | ||
| self._stale_duration = stale_duration | ||
| self._use_dynamic_stale_duration = stale_duration is None | ||
| self._stale_duration = stale_duration if stale_duration is not None else timedelta(seconds=0) |
Contributor
There was a problem hiding this comment.
[optional] Wondering if it won't be simpler to make this a timestamp rather than a duration.
Comment on lines
+293
to
+297
| """ | ||
| For each token type, verifies: | ||
| - Stale tokens trigger async refresh (returns old token immediately) | ||
| - Expired tokens trigger blocking refresh (blocks and returns new token) | ||
| """ |
Contributor
There was a problem hiding this comment.
Can we separate this into two tests? Also, is there a way we could avoid waiting for 1 second in the loop?
Contributor
Author
There was a problem hiding this comment.
Good point, 1 second is too much. I think without changing the implementation of blocking_token() I can drop this to 0.1.
Does that work?
Contributor
There was a problem hiding this comment.
Discussed offline, let's proceed with the code as it is and maybe follow-up with using threading to wait exactly the right amount of time. The goal here is to make sure that we are most wasting seconds on a test suite that should run in 2 digits milliseconds.
renaudhartert-db
approved these changes
Mar 2, 2026
Address PR feedback by: - Splitting test_dynamic_stale_period into two tests: - test_dynamic_stale_period_blocking_refresh: expired token triggers blocking refresh - test_dynamic_stale_period_async_refresh: stale token triggers async refresh - Reducing the post-unblock wait from 1s to 0.1s Full removal of the wait (e.g. via threading or explicit event) to be done in a follow-up.
mihaimitrea-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mihaimitrea-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mihaimitrea-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
mihaimitrea-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement dynamic token stale period for improved auth reliability
Extends the token refresh buffer from a fixed 5 minutes to a dynamic period that adapts to token lifetime, improving reliability across different token types while maintaining backward compatibility.
The TTL is computed based on the time to live at the moment the token is received and not it's real TTL. For example, if the token has a TTL of 60 mins, but has been acquired 20 mins before being used by the SDK (e.g. though the CLI), it's TTL will be 60 - 20 = 40 mins.
Changes:
Backward compatibility:
Implementation:
Token behavior examples:
Testing: