[PLAT-129166] fix parallel db update#12
Merged
jnyi merged 2 commits intodatabricks:db_mainfrom Mar 15, 2025
Merged
Conversation
Signed-off-by: Yi Jin <yi.jin@databricks.com>
hczhu-db
approved these changes
Mar 14, 2025
pkg/controller/controller.go
Outdated
| if p.Status.Phase == corev1.PodRunning { | ||
| return 1 // Running pods are ranked higher and will be updated last. | ||
| } | ||
| return 0 // Running pods are ranked lower and will be updated first. |
jnyi
force-pushed
the
PLAT-129166-parallel-db-update
branch
9 times, most recently
from
6fceaa3 to
7c89b53
Compare
Signed-off-by: Yi Jin <yi.jin@databricks.com>
jnyi
force-pushed
the
PLAT-129166-parallel-db-update
branch
from
7c89b53 to
71ce581
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ensure only update the next statefulset until previous statefulset is considered ready. We should check desired replicas using Spec.Replicas instead of Status.Replicas which will overlook when multiple pods are deleted. See previous incident:
Tested this works: