-
Notifications
You must be signed in to change notification settings - Fork 80
Add SQL Server Profiler #2151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add SQL Server Profiler #2151
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2151 +/- ##
===========================================
- Coverage 65.23% 13.47% -51.77%
===========================================
Files 100 105 +5
Lines 8504 8673 +169
Branches 875 875
===========================================
- Hits 5548 1169 -4379
- Misses 2769 7445 +4676
+ Partials 187 59 -128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 51/51 passed, 11 flaky, 3m35s total Flaky tests:
Running from acceptance #3061 |
| from databricks.labs.lakebridge.connections.database_manager import DatabaseManager | ||
|
|
||
|
|
||
| def get_sqlserver_reader( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Database manager should already have the MSSQLConnector we should be using that.
| steps: | ||
| - name: activity_extract | ||
| type: python | ||
| extract_source: src/databricks/labs/lakebridge/resources/assessments/mssql/activity_extract.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we just run sql queries directly? do we need python wrapper for SQL Server profilers?
Changes
What does this PR do?
This PR adds a new profiler for
mssql.Relevant implementation details
This profiler closely follows the implementation of the Azure Synapse profiler. However, this implementation provides a
last_execution_timeparam for allmssqlserver queries, allowing for a future scheduler component to hook in an repeat queries.Caveats/things to watch out for when reviewing:
This profiler will not support on-prem
mssqlservers.Linked issues
N/A
Functionality
databricks labs lakebridge ...Tests