Set the embeddings server url for CDC mixer

[clincoln8]

Spawn CDC mixer to point to the local embeddings server and set the index to use in/v2/resolve.

Indicator resolution will not be available for custom dc until either EnableEmbeddingsResolver flag is true by default or is cleaned up entirely. Until then, the returned message for /v2/resolve calls with resolver=indicator will be "Resolving indicators is not enabled for this environment."

Testing

Deployed cdc image to dev cloud run service using this temp pr (https://github.com/datacommonsorg/website/pull/5927/changes) to enable the flag locally.

[gemini-code-assist]

Summary of Changes

Hello @clincoln8, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the cdc mixer service's startup script by implementing conditional logic to configure the embeddings server URL. This change allows the mixer to connect to an embeddings server only when a specific model-enabling flag is active, providing greater flexibility in deployment and resource management.

Highlights

• Mixer Configuration: The pull request introduces a mechanism to dynamically set the --embeddings_server_url argument for the mixer binary.
• Conditional Embeddings Server URL: The embeddings server URL (localhost:6060) is now conditionally applied to the mixer command only when the ENABLE_MODEL environment variable is set to "true".

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to add a conditional command-line argument --embeddings_server_url to the mixer command based on the ENABLE_MODEL environment variable. However, a high-severity command injection vulnerability has been identified in the build/cdc_services/run.sh script. The introduction of the $MIXER_ARGS variable without proper shell quoting, along with existing unquoted variables, creates a risk of arbitrary command execution. A more robust approach using a bash array for handling optional arguments is suggested to improve maintainability and mitigate word splitting issues.

[clincoln8]

/gemini review

[gemini-code-assist]

Code Review

This pull request configures the CDC mixer to use an embeddings server by setting the --embeddings_server_url when a model is enabled. The changes in build/cdc_services/run.sh are logical and correctly implement this. I've added one suggestion to improve maintainability by replacing a hardcoded port number with a variable.

[keyurva]

Indicator resolution will not be available for custom dc until either EnableEmbeddingsResolver flag is true by default or is cleaned up entirely

Can we remove this flag entirely?