[do not submit] enable embeddings resolver for custom dc

[clincoln8]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @clincoln8, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enabling the embeddings resolver functionality within the mixer service for custom deployments. It achieves this by introducing a dedicated feature flag configuration file that activates the resolver and by enhancing the service's startup script to dynamically configure the necessary embeddings server URL based on an environment variable. These changes ensure that the mixer service can properly utilize the embeddings resolver when deployed in specific environments.

Highlights

• New Feature Flag Configuration: A new YAML file, mixer_custom.yaml, has been introduced to manage feature flags, specifically enabling the EnableEmbeddingsResolver flag.
• Docker Image Update: The Dockerfile is updated to include the new mixer_custom.yaml file in the Docker image, ensuring the feature flag configuration is available at runtime.
• Dynamic Embeddings Server Configuration: The run.sh script now conditionally passes an --embeddings_server_url argument to the mixer service if the ENABLE_MODEL environment variable is set to 'true', allowing for dynamic configuration of the embeddings server.
• Mixer Service Integration: The mixer service startup command in run.sh has been modified to load feature flags from mixer_custom.yaml and to incorporate the dynamically set embeddings server URL.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enables the embeddings resolver for custom Data Commons instances by introducing a feature flag. The changes involve adding a mixer_custom.yaml configuration file, updating the Dockerfile to include it, and modifying the run.sh script to pass the necessary arguments to the mixer process. My review includes suggestions to improve the robustness of the shell script by using a bash array for arguments and to follow best practices for file formatting by adding a newline at the end of the new YAML file.

[gemini-code-assist]

It's a best practice for text files to end with a newline character. Some tools may not process the last line correctly if it's missing. Please add a newline at the end of this file.

  EnableEmbeddingsResolver: true

[gemini-code-assist]

Using a string to build up command-line arguments is fragile and can lead to issues with word splitting, especially if arguments contain spaces. A more robust approach is to use a bash array. This will make the script more maintainable and less error-prone.

Suggested change

	MIXER_ARGS=""
	if [[ $ENABLE_MODEL == "true" ]]; then
	MIXER_ARGS="--embeddings_server_url=http://localhost:6060"
	fi
	MIXER_ARGS=()
	if [[ $ENABLE_MODEL == "true" ]]; then
	MIXER_ARGS+=(--embeddings_server_url=http://localhost:6060)
	fi

[gemini-code-assist]

In conjunction with the previous suggestion to use an array for MIXER_ARGS, you should expand the array using "${MIXER_ARGS[@]}". This ensures each argument is passed correctly, preventing issues with word splitting and globbing.

Suggested change

	$MIXER_ARGS &
	"${MIXER_ARGS[@]}" &