Skip to content

Conversation

@89snake89
Copy link
Contributor

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Nov 1, 2025

PR Summary

  • Improved Representation of Irish Addresses
    This change adds several new attributes to the formatting of Irish addresses. With these additions, the format will better represent the actual structures of addresses in Ireland.

  • Support for Irish Locale in Data Generation
    A new locale identifier, IE_FAKER, has been introduced. This allows for the generation of Irish locale-specific addresses during testing.

  • Testing of Newly-Implemented Irish Address Format
    A new test case has been implemented which utilizes the irishAddress() method. This test ensures that the generated Irish addresses comply with validation rules by matching a pre-defined regular expression (regex).

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.32%. Comparing base (6ca6258) to head (7567010).
⚠️ Report is 180 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1714      +/-   ##
============================================
- Coverage     92.45%   92.32%   -0.13%     
- Complexity     3329     3434     +105     
============================================
  Files           330      337       +7     
  Lines          6550     6779     +229     
  Branches        643      670      +27     
============================================
+ Hits           6056     6259     +203     
- Misses          339      354      +15     
- Partials        155      166      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asolntsev asolntsev added this to the 2.6.0 milestone Nov 1, 2025
@bodiam
Copy link
Contributor

bodiam commented Nov 4, 2025

Nice, looks good to me, thank you @89snake89 !

@bodiam bodiam merged commit e780354 into datafaker-net:main Nov 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants