Skip to content

Add compile flag for replacing Dataform core in project directory #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattkocak wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add compile flag for replacing Dataform core in project directory #1786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions cli/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ import { targetAsReadableString } from "df/core/targets";
import { dataform } from "df/protos/ts";
import { formatFile } from "df/sqlx/format";
import parseDuration from "parse-duration";
import { promisify } from "util";
import * as childProcess from "child_process";

const RECOMPILE_DELAY = 500;

Expand Down Expand Up @@ -168,6 +170,7 @@ const jobPrefixOption: INamedOption<yargs.Options> = {
const testConnectionOptionName = "test-connection";

const watchOptionName = "watch";
const replaceCoreOptionName = "replace-core";

const dryRunOptionName = "dry-run";
const runTestsOptionName = "run-tests";
Expand Down Expand Up @@ -316,6 +319,15 @@ export function runCli() {
default: false
}
},
{
name: replaceCoreOptionName,
option: {
describe: `For Dataform core development purposes. Whether to replace the @dataform/core build in the
project directory with code changes present in the current directory.`,
type: "boolean",
default: false
}
},
jsonOutputOption,
timeoutOption,
...ProjectConfigOptions.allYargsOptions
Expand All @@ -324,6 +336,12 @@ export function runCli() {
const projectDir = argv[projectDirMustExistOption.name];

async function compileAndPrint() {
if (argv[replaceCoreOptionName]) {
print("Building & replacing @dataform/core in project directory...\n");
await promisify(childProcess.exec)(`bazel build packages/@dataform/core:bundle.js \
&& cp bazel-bin/packages/@dataform/core/bundle.js ${projectDir}/node_modules/@dataform/core/`);
print("@dataform/core replacement complete\n");
}
if (!argv[jsonOutputOption.name]) {
print("Compiling...\n");
}
Expand Down