-
Notifications
You must be signed in to change notification settings - Fork 313
Add lidar object segmentation op #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a LiDARSegmentationMapper for segmenting LiDAR data, leveraging the mmdet3d library. The overall implementation is a good starting point, but there are several areas that require attention. I've identified a critical bug in error handling within prepare_mmlab_model, where an exception is not properly raised. Additionally, the same function introduces a heavy dependency by cloning an entire Git repository and contains hardcoded logic for model downloading, which impacts maintainability and portability. The new test file also has significant code duplication that could be refactored. I have provided specific comments and suggestions to address these issues.
Built upon the mmdet3d Inferencer.