Skip to content

Conversation

@Qirui-jiao
Copy link
Collaborator

Built upon the mmdet3d Inferencer.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a LiDARSegmentationMapper for segmenting LiDAR data, leveraging the mmdet3d library. The overall implementation is a good starting point, but there are several areas that require attention. I've identified a critical bug in error handling within prepare_mmlab_model, where an exception is not properly raised. Additionally, the same function introduces a heavy dependency by cloning an entire Git repository and contains hardcoded logic for model downloading, which impacts maintainability and portability. The new test file also has significant code duplication that could be refactored. I have provided specific comments and suggestions to address these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants