-
Notifications
You must be signed in to change notification settings - Fork 307
feat: add memory reservation parameters for Ray minhash deduplication #863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add actor_memory param for EdgeBuffer/BTSUnionFind actors - Add task_memory param for map_batches tasks - Add actor readiness check before processing - For billion-row scale processing, recommended settings: - actor_memory: 20_000_000_000 (20GB) - task_memory: 2_000_000_000 (2GB) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary of ChangesHello @xyuzh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the robustness and scalability of the Ray-based MinHash deduplication process by introducing explicit memory management parameters. Users can now reserve specific amounts of memory for Ray actors and Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces memory reservation parameters (actor_memory and task_memory) for Ray-based MinHash deduplication to handle large-scale datasets more effectively and prevent out-of-memory issues. The changes include updating actor and task creation to use these memory settings, adding a readiness check for actors, and refactoring map_batches calls. My review focuses on improving the robustness and maintainability of these changes. I've suggested ensuring all created actors are checked for readiness, not just a subset, and refactoring duplicated code for setting up map_batches arguments into a helper method for better code reuse and clarity. Overall, the changes are a good step towards making the deduplication process more scalable.
- Wait for EdgeBuffer actors in addition to BTSUnionFind actors - Extract duplicated map_batches kwargs into _get_map_batches_kwargs() helper 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary
actor_memoryparameter for EdgeBuffer/BTSUnionFind actors (bytes)task_memoryparameter for map_batches tasks (bytes)Background
For billion-row scale deduplication, memory pressure can cause OOM issues. These parameters allow users to reserve memory for actors and tasks:
Test plan
🤖 Generated with Claude Code