Skip to content

Conversation

@xyuzh
Copy link
Contributor

@xyuzh xyuzh commented Dec 22, 2025

Summary

  • Add actor_memory parameter for EdgeBuffer/BTSUnionFind actors (bytes)
  • Add task_memory parameter for map_batches tasks (bytes)
  • Add actor readiness check before processing
  • Refactor map_batches calls to use kwargs dict pattern

Background

For billion-row scale deduplication, memory pressure can cause OOM issues. These parameters allow users to reserve memory for actors and tasks:

ray_bts_minhash_deduplicator:
  actor_memory: 20_000_000_000  # 20GB per actor
  task_memory: 2_000_000_000    # 2GB per task

Test plan

  • Test with existing dedup configs (no memory params - backward compatible)
  • Test with memory params on large-scale data

🤖 Generated with Claude Code

- Add actor_memory param for EdgeBuffer/BTSUnionFind actors
- Add task_memory param for map_batches tasks
- Add actor readiness check before processing
- For billion-row scale processing, recommended settings:
  - actor_memory: 20_000_000_000 (20GB)
  - task_memory: 2_000_000_000 (2GB)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @xyuzh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the robustness and scalability of the Ray-based MinHash deduplication process by introducing explicit memory management parameters. Users can now reserve specific amounts of memory for Ray actors and map_batches tasks, directly addressing potential Out-Of-Memory issues that arise when processing extremely large datasets. These changes aim to provide greater control over resource allocation, leading to more stable and efficient deduplication operations at a billion-row scale.

Highlights

  • Memory Reservation for Ray Actors: Introduced an actor_memory parameter that allows users to specify memory reservation in bytes for EdgeBuffer and BTSUnionFind Ray actors, crucial for managing resources in large-scale deduplication.
  • Memory Reservation for Ray Tasks: Added a task_memory parameter to reserve memory in bytes for map_batches tasks, preventing Out-Of-Memory (OOM) issues during intensive processing.
  • Actor Readiness Check: Implemented a readiness check for BTSUnionFind actors using ray.get([uf.__ray_ready__.remote() for uf in self.union_find_list]) to ensure all actors are fully initialized before processing begins.
  • Refactored map_batches Calls: Updated map_batches invocations to use a keyword argument dictionary pattern, making the code cleaner and more flexible for passing dynamic parameters like memory.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces memory reservation parameters (actor_memory and task_memory) for Ray-based MinHash deduplication to handle large-scale datasets more effectively and prevent out-of-memory issues. The changes include updating actor and task creation to use these memory settings, adding a readiness check for actors, and refactoring map_batches calls. My review focuses on improving the robustness and maintainability of these changes. I've suggested ensuring all created actors are checked for readiness, not just a subset, and refactoring duplicated code for setting up map_batches arguments into a helper method for better code reuse and clarity. Overall, the changes are a good step towards making the deduplication process more scalable.

- Wait for EdgeBuffer actors in addition to BTSUnionFind actors
- Extract duplicated map_batches kwargs into _get_map_batches_kwargs() helper

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant