-
Notifications
You must be signed in to change notification settings - Fork 307
New Ops for physical AI: annotate generate replay convert #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: embodied_ai
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @1van2ha0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the data processing capabilities for physical AI by integrating with Isaac Lab and supporting the LeRobot dataset format. It introduces a suite of new mapper operators that cover the entire pipeline from annotating raw robot demonstrations, generating synthetic mimic datasets, replaying and recording randomized simulations, to converting the processed data into a standardized format suitable for training robotic agents. These additions streamline the workflow for researchers and developers working with simulated robotic data, enhancing the efficiency and versatility of the data processing framework. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
此PR为物理AI数据处理添加了四个新的mapper算子,集成了Isaac Sim,这是一个重要的功能增强。新的算子annotate_demos、generate_dataset、replay_randomized和convert_to_lerobot覆盖了从种子数据到可训练数据的完整流程。PR还包括了文档更新、新的依赖项和单元测试。代码结构总体良好,但存在一些关键问题需要解决,特别是关于安全(eval的使用)、依赖冲突和潜在的资源泄漏。此外,还有几个中等严重性的问题涉及代码风格和最佳实践,应予以修复以提高可维护性。
添加算子:annotate_demos,generate_dataset,replay_randomized,convert_to_lerobot,支持从种子数据到可训练的lerobot数据的批量化处理
更新了对应的doc文档,为对应算子添加了单元测试与使用示例