This repository was archived by the owner on Apr 17, 2018. It is now read-only.
[master] Use a more RFC2396 complaint regex pattern for the :url format validation #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current regex pattern was tripping on a number of valid URLs, so this change updates it to use the URI module's regexp class. To maintain some compatability with the old regex, I have limited the valid urls accepted by this regex to the http and https schemes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current format's url regular expression pattern was tripping on a number of valid URLs, so this change updates it to use
URI.regexp, which is provided by the ruby stdlib. To maintain some compatibility with the old regex, I have limited the valid urls accepted by this regex to only thehttpandhttpsschemes, which may or may not be desired.