Get-DbaHelpIndex - Fix SQL injection and remove SQL 2005 code path#10302
Merged
potatoqualitee merged 1 commit intodevelopmentfrom Apr 4, 2026
Merged
Get-DbaHelpIndex - Fix SQL injection and remove SQL 2005 code path#10302potatoqualitee merged 1 commit intodevelopmentfrom
potatoqualitee merged 1 commit intodevelopmentfrom
Conversation
- Escape single quotes in ObjectName to prevent SQL injection when building the @TableName DECLARE/SET statement - Remove unused $SizesQuery2005 block and its conditional branching; Connect-DbaInstance -MinimumVersion 10 already enforces SQL 2008+ - Update docs to reflect SQL Server 2008+ minimum version requirement (do Get-DbaHelpIndex) Co-authored-by: Andreas Jordan <andreasjordan@users.noreply.github.com>
Member
|
Thank you 👍🏼 |
Member
|
Oh, and regarding SQL injection: this is CLI so I'm not convinced this is an issue. People do SQL injection on the web precisely to get to your CLI. With dbatools, we're already there. Still, it's good coding practice and I'll be enforcing it in dbatools 3.0 bc it can be pretty. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8716
Generated with Claude Code