Import-DbaCsv, Export-DbaCsv - Normalize table/schema names via Get-ObjectNameParts#10306
Draft
andreasjordan wants to merge 1 commit intodevelopmentfrom
Draft
Import-DbaCsv, Export-DbaCsv - Normalize table/schema names via Get-ObjectNameParts#10306andreasjordan wants to merge 1 commit intodevelopmentfrom
andreasjordan wants to merge 1 commit intodevelopmentfrom
Conversation
…bjectNameParts Fixes inconsistency where commands with bracketed table names (e.g. [My.Table]) failed because sys.tables stores bare names without brackets. - Import-DbaCsv: normalize $table/$schema with Get-ObjectNameParts before using them in parameterized metadata queries (sys.tables, sys.schemas, INFORMATION_SCHEMA.COLUMNS). Also handles two-part schema.table input. - Export-DbaCsv: replace naive dot-split regex with Get-ObjectNameParts so that names like [Gross.Table.Name] are correctly parsed instead of being split on the dot inside the brackets. Closes #9010 (do *Csv*) Co-authored-by: Andreas Jordan <andreasjordan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes inconsistency where commands with bracketed table names (e.g. [My.Table]) failed because sys.tables stores bare names without brackets.
Generated with Claude Code
Edit of andreasjordan:
Fixes part of #9010 - more PRs need to follow. So we keep the issue open but limit this PR to the DbaCsv commands. After this is merged we can find other commands that need the same fix.
IMPORTANT: This is a breaking change so maybe merge later together with other breaking changes and release a new version 2.8.0