V6.3.3 dev - CRAN submission #392
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses various issues from the latest CRAN submission: https://wiki.datashield.org/en/opmanag/cran-submission-2025-06-25-issues
Details:
Please always write package names, software names and API (application
programming interface) names in single quotes in title and description.
e.g: --> 'DataSHIELD'
Please note that package names are case sensitive.
For more details:
<https://contributor.r-project.org/cran-cookbook/description_issues.html#formatting-software-names>
Status: Addressed [RVD]
We see: Unknown, possibly misspelled, fields in DESCRIPTION:
'AggregateMethods' 'AssignMethods' 'Options'
Status: Addressed [RVD]
Note: RVD created a new file
inst/DATASHIELDwhere these sections were relocated.Please add \value to .Rd files regarding exported methods and explain
the functions results in the documentation. Please write about the
structure of the output (class) and also what the output means. (If a
function does not return a value, please document that too, e.g.
\value{No return value, called for side effects} or similar)
For more details:
<https://contributor.r-project.org/cran-cookbook/docs_issues.html#missing-value-tags-in-.rd-files>
-> Missing Rd-tags in up to 13 .Rd files, e.g.:
BooleDS.Rd: \value
checkPermissivePrivacyControlLevel.Rd: \value
glmDS1.Rd: \value
glmDS2.Rd: \value
lexisDS1.Rd: \value
lexisDS2.Rd: \value
...
Status: Addressed [RVD]
Notes: RVD used the function
checkhelper::find_missing_tags()to aid finding missing tags.You write information messages to the console that cannot be easily
suppressed.
It is more R like to generate objects that can be used to extract the
information a user is interested in, and then print() that object.
Instead of print()/cat() rather use message()/warning() or
if(verbose)cat(..) (or maybe stop()) if you really have to write text to
the console. (except for print, summary, interactive functions)
For more details:
<https://contributor.r-project.org/cran-cookbook/code_issues.html#using-printcat>
Status: Addressed [RVD]