Skip to content

Conversation

@villegar
Copy link
Contributor

@villegar villegar commented Jul 8, 2025

This pull request addresses various issues from the latest CRAN submission: https://wiki.datashield.org/en/opmanag/cran-submission-2025-06-25-issues

Details:

Please always write package names, software names and API (application
programming interface) names in single quotes in title and description.
e.g: --> 'DataSHIELD'
Please note that package names are case sensitive.
For more details:
<https://contributor.r-project.org/cran-cookbook/description_issues.html#formatting-software-names>

Status: Addressed [RVD]


We see: Unknown, possibly misspelled, fields in DESCRIPTION:
     'AggregateMethods' 'AssignMethods' 'Options'

Status: Addressed [RVD]

Note: RVD created a new file inst/DATASHIELD where these sections were relocated.


Please add \value to .Rd files regarding exported methods and explain
the functions results in the documentation. Please write about the
structure of the output (class) and also what the output means. (If a
function does not return a value, please document that too, e.g.
\value{No return value, called for side effects} or similar)
For more details:
<https://contributor.r-project.org/cran-cookbook/docs_issues.html#missing-value-tags-in-.rd-files>

-> Missing Rd-tags in up to 13 .Rd files, e.g.:
      BooleDS.Rd: \value
      checkPermissivePrivacyControlLevel.Rd: \value
      glmDS1.Rd: \value
      glmDS2.Rd: \value
      lexisDS1.Rd: \value
      lexisDS2.Rd: \value
      ...

Status: Addressed [RVD]

Notes: RVD used the function checkhelper::find_missing_tags() to aid finding missing tags.


You write information messages to the console that cannot be easily
suppressed.
It is more R like to generate objects that can be used to extract the
information a user is interested in, and then print() that object.
Instead of print()/cat() rather use message()/warning() or
if(verbose)cat(..) (or maybe stop()) if you really have to write text to
the console. (except for print, summary, interactive functions)
For more details:
<https://contributor.r-project.org/cran-cookbook/code_issues.html#using-printcat>

Status: Addressed [RVD]

@StuartWheater StuartWheater merged commit 89e1154 into datashield:v6.3.3-dev Jul 8, 2025
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants