[logs][s] Added better error logs theme loading errors #186
+50
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he previous was only a warning without any extra text
EvgeniiaVak
reviewed
Oct 13, 2020
Contributor
|
I like to have more logs 👍 |
Contributor
|
@anuveyatsu @starsinmypockets are there any rules against error level logs? (Asking this because I see |
Member
|
@EvgeniiaVak no, there is no such rules. Feel free to improve it 👍 @leomrocha looks like this PR also includes prettier not just better error logs. |
EvgeniiaVak
reviewed
Nov 20, 2020
leomrocha
force-pushed
the
feature/theme-logs
branch
from
256aa98 to
04d5a39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More descriptive and easy to follow error logs for theme failures