Improved matrix softfont DECDLD and optimized charsets changes. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the softfont string into more readable header and characters chunks. Keep track of currently active charset so we can output font changes only when necessary.
Contributor
Author
|
Not sure if you'd consider those improvements though, feel free to discard this and use the puts version if you prefer the black box DECDLD approach and want to avoid the loop. If you want more details on soft fonts, the VT420 programme's regerence guide contains a better explanation than previous models. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes for #2
Hopefully this fixes the bus error with the long string, and makes it both more readable and slightly more efficient.