Add highlighted overlay for webview2, #99
Conversation
…r both visual hosting and windowed hosting mode
| xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" | ||
| xmlns:local="clr-namespace:wv2util" | ||
| mc:Ignorable="d" | ||
| Title="Overlay" Height="450" Width="800" WindowStyle="None" AllowsTransparency="True" Opacity="0.25" ResizeMode="NoResize" ShowInTaskbar="False" Topmost="False" Focusable="False" IsHitTestVisible="False" IsTabStop="False" Background="#FF84B9FF" MouseUp="Window_MouseUp"> |
There was a problem hiding this comment.
The blue color is maybe too nice looking and can be hard to tell its actually not part of the web content. How about changing the color to orange and is it practical to add a darker orange border around the edge?
|
|
||
| private void UpdateOverlayToMatchTarget() | ||
| { | ||
| /* |
There was a problem hiding this comment.
Is this commented out code still useful? We should either uncomment and fix the code or remove the comment.
| { | ||
| PInvoke.User32.SetWindowPos(m_thisHwnd, prevTargetHwnd, 0, 0, 0, 0, | ||
| PInvoke.User32.SetWindowPosFlags.SWP_NOSIZE | | ||
| PInvoke.User32.SetWindowPosFlags.SWP_NOMOVE); |
There was a problem hiding this comment.
In the video in the PR description the blue highlight window is in the correct location but its above the webview2utilities window. This code looks like it wants to change the z-order to be just above the webview2 window which I would think should be below the webview2utilities top level window?
| UpdateOverlayToMatchTarget(); | ||
| this.ShowActivated = false; | ||
|
|
||
| m_checkForUpdatesTimer = new Timer(500); |
There was a problem hiding this comment.
In the PR video it looks like the highlight disappears quickly after clicking on the host app entry. We probably want to leave the overlay up as long as the host app entry is selected - or at least have it last a while longer before fading out.
Adding works on Win32 sample app for both visual hosting and windowed hosting mode
Wv2Utils-FHL-overlay.mp4