Skip to content

Conversation

@AA-Turner
Copy link
Contributor

Suggested in response to #273 (comment). Another alternative would be to automatically make a release, but I don't know if you'd want that.

A

print(
f"Local version {local_version} does not match upstream version {upstream_version}"
)
os.environ["LIBPHONENUMBER_UPSTREAM_VERSION"] = upstream_version
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will work – IIRC environment variables are only visible to child processes, not parents.

with:
# language=JavaScript
script: |
await github.rest.issues.create({
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this create a new issue on every failed run of the workflow?

I'm thinking that if I'm away for a week and a release happens to come out at the start, would I return to 14 identical issues? :-)

@daviddrysdale
Copy link
Owner

Thanks, this seems like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants