Open
Conversation
davidferguson
force-pushed
the
addcinema-glasgowfilmtheatre
branch
from
c2d3152 to
17e7ccc
Compare
Owner
|
Rebased and fixed so it now doesn't include savoy cinemas. Will do a code review shortly. |
Owner
davidferguson
left a comment
davidferguson
left a comment
There was a problem hiding this comment.
Looks good, a couple of minor changes to deal with "Noirvember" but other than that it's nearly ready to merge.
| # if no format is given, assume digital | ||
| if len(film_attributes['format']) == 0: | ||
| film_attributes['format'] = ['digital'] | ||
| # clean up the title by removing trailing characters, |
Owner
There was a problem hiding this comment.
In November the GFT have Noirvember - it would be good to strip that out of the film name.
Additionally the Noirvember films have + introduction in their title - we could take these out too? Maybe have an attribute for whether the screening is having an introduction?
| for meta_item in metadata.find_all('li'): | ||
| meta_label = meta_item.find('span', class_='meta-label').text.strip() | ||
| meta_value = meta_item.find('span', class_='meta-value').text.strip() | ||
| if meta_label == 'Year of Production': |
Owner
There was a problem hiding this comment.
For some films (like the noirvember ones) the label is simply Year, not Year of Production - can we handle both cases please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the Glasgow Film Theatre to the archiver.
Some notes:
autism-friendlyanddementia-friendlyas attributes since the HTML exposed these. However, I'm not sure if we will want to have these attributes in the final version.STANDARD_DAYS_AHEAD. I am preparing a separate PR to ensure that the archiver class filters out results beyondSTANDARD_DAYS_AHEAD.Edit: oh dear, I seem to have managed to somehow include the
Savoyarchiver in this PR. No idea how I did that...